-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracing] support grpc protocol endpoint #7721
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @TianxiangShen. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b7a89ca
to
454bd62
Compare
The following is the coverage report on the affected files.
|
@kmjayadeep FYI |
@TianxiangShen thank you for your PR! |
/kind feature |
/test pull-tekton-pipeline-go-coverage-df |
@TianxiangShen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
454bd62
to
73b28fa
Compare
@afrittoli Thanks for the instruction. I've signed the CLA, not sure what the CLA checking still failed, please let me know if there's any thing I should do. |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Hi @TianxiangShen , The PR #7547 would likely get merged soon. You will have to move the logic from |
@TianxiangShen: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/easycla |
1 similar comment
/easycla |
/ok-to-test |
@TianxiangShen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Changes
This PR introduces support for gRPC-based tracing providers in addition to the existing HTTP-based Jaeger tracing. The main changes include modifications to the
reinitialize
function and the addition of a new functioncreategRPCTracerProvider
. Previously, tracing configuration was limited to HTTP endpoints for Jaeger, which restricted usage in environments where the trace collector only supports the gRPC protocol. These changes enable Tekton to be more versatile in its support for tracing backends, catering to a broader range of tracing infrastructure.The
reinitialize
function now parses the endpoint's scheme to determine whether to initialize an HTTP or gRPC tracer provider. For gRPC, thecreategRPCTracerProvider
function sets up a tracer provider using the OpenTelemetry protocol (OTLP) over gRPC, without requiring TLS credentials for simplicity and ease of integration. This modification ensures that Tekton can integrate with tracing systems that communicate over gRPC, enhancing its compatibility and flexibility in observability configurations.Submitter Checklist
Release Notes