matrix taskRun name updated to end with the instance count
#7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix creates multiple taskRuns using the specified combination of inputs. The taskRun name in general is predictable unless it exceeds the max. number of characters (63). When the combination of a pipelineTask name and the pipelineRun name exceeds 63 characters, the taskRun names looses all their instance indices. Updating the taskRun name generation such that in case of a matrix task, when the generated taskRun name exceeds k8s restriction of 63 characters, the taskRun name is truncated and instance id of matrix is appended. Signed-off-by: Priti Desai <[email protected]>
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
vdemeester
approved these changes
Jan 24, 2024
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
matrix creates multiple taskRuns using the specified combination of inputs. The taskRun name in general is predictable unless it exceeds the max. number of characters (63). When the combination of a pipelineTask name and the pipelineRun name exceeds 63 characters, the taskRun names looses all their instance indices.
Updating the taskRun name generation such that in case of a matrix task, when the generated taskRun name exceeds k8s restriction of 63 characters, the taskRun name is truncated and instance id of matrix is appended.
#7562
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes