Remove .envrc and show an example in .envrc.sample #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
tekton-robot
added
the
size/XS
The .envrc file is used by direnv to load the environment variables and having this file in the repository can cause problems when the user has already one in his home directory. Moreover this file automatically loads silently the environment variables from .env.sample bypassing the explicit "direnv allow" that usually needed with .envrc which can be a potential security issue. This is still a useful file and to know about for contributors so we keep the sample file in .envrc.sample and let user copy it to .envrc if they want to use it. Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
remove-direnv
branch
from
9b7e94d to
6ff3336
Compare
tekton-robot
added
size/S
chmouel
changed the title
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .envrc file is used by direnv to load the environment variables and
having this file in the repository can cause problems when the user has
already one in his/her home directory.
Moreover this file automatically loads silently the environment
variables from .env bypassing the explicit "direnv allow" that
usually needed with .envrc which can be a potential security issue.
This is still a useful file and to know about for contributors so we
keep the sample file in .envrc.sample and let user copy it to .envrc if
they want to use it.
/kind misc
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes