Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace out of date publish images with cgr.dev equivalents. #7359

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Nov 14, 2023

Changes

These should be drop in replacements with full shells.

Grype Output:

gcr.io/go-containerregistry/crane:debug cgr.dev/chainguard/crane:latest-dev
1 Critical
5 High
10 Medium
11 Negligible
2 Unknown
1 Medium
golang:1.18.7 cgr.dev/chainguard/go:latest-dev
140 Critical
416 High
19 Low
337 Medium
452 Negligible
8 Unknown

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@wlynch
Copy link
Member Author

wlynch commented Nov 14, 2023

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 14, 2023
@imjasonh
Copy link
Member

FWIW, it looks like gcr.io/go-containerregistry/crane:debug hasn't been updated since Mon Jul 31 2023 21:49:55, which is likely when the repo stopped having access to GCP. I don't know the current ownership of that project.

If there's interest, I think we could publish crane images to ghcr.io/google/go-containerregistry:debug where it can continue getting updates. Until then, the cgr.dev image is probably going to be the best place to get updates for now.

tekton/publish.yaml Outdated Show resolved Hide resolved
tekton/publish.yaml Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@wlynch wlynch requested a review from afrittoli November 14, 2023 22:13
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@Yongxuanzhang
Copy link
Member

Cool! So the images are created and hosted by chainguard? How do they fix those vulberabilities?

@wlynch
Copy link
Member Author

wlynch commented Nov 15, 2023

Cool! So the images are created and hosted by chainguard?

Yep! https://edu.chainguard.dev/chainguard/chainguard-images/overview/ for more details.

How do they fix those vulberabilities?

Magic 🧙
(really a lot of hard work and automation 💪 🤖 )

@vdemeester
Copy link
Member

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 29, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2024
@vdemeester
Copy link
Member

@wlynch @imjasonh still needed ? (if yes, it needs a rebase 🙏🏼 )

@afrittoli
Copy link
Member

@wlynch ping 🙏

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2024
@wlynch
Copy link
Member Author

wlynch commented Feb 26, 2024

rebased!

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @tektoncd/core-maintainers

@tekton-robot tekton-robot requested a review from a team February 26, 2024 16:42
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@tekton-robot tekton-robot merged commit 695f622 into tektoncd:main Apr 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants