change bundle resolver to use secret instead of service account

[Yongxuanzhang]

Changes

This commit fixes #7159. The bundle resolver's service account doesn't have the permission to fetch the service account which contains the credientials to pull bundle, and the error is also omitted. This commit changes to use secret directly, without granting SA read permissions to resolver.

/kind bug

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: Bundle resolve uses secret to pull bundle Tasks/Pipelines from private registry instead of Service Account. Please update your bundle resolver ref to use secret.

[tekton-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/resolver.go	95.5%	91.7%	-3.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/resolver.go	95.5%	91.7%	-3.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/resolver.go	95.5%	95.8%	0.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/resolver.go	95.5%	95.8%	0.4

[JeromeJu]

Thanks for the fix @Yongxuanzhang .
I agree with the commit message that this is a bug that might block some of Tekton users. But one question I got is regarding resolver compatibility policy, do we still need to support the previous SA fields 🤔 ?

[Yongxuanzhang]

Thanks for the fix @Yongxuanzhang . I agree with the commit message that this is a bug that might block some of Tekton users. But one question I got is regarding resolver compatibility policy, do we still need to support the previous SA fields 🤔 ?

It never works, I don't see values here to stick to the policy 🤷‍♂️
And I don't think this is an api change... it is changing the preserved param in resolver

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/params.go	90.6%	92.3%	1.7
pkg/resolution/resolver/bundle/resolver.go	95.5%	95.8%	0.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/params.go	90.6%	92.3%	1.7
pkg/resolution/resolver/bundle/resolver.go	95.5%	95.8%	0.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/params.go	90.6%	92.3%	1.7
pkg/resolution/resolver/bundle/resolver.go	95.5%	95.8%	0.4

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/params.go	90.6%	92.0%	1.4
pkg/resolution/resolver/bundle/resolver.go	95.5%	96.3%	0.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/params.go	90.6%	92.0%	1.4
pkg/resolution/resolver/bundle/resolver.go	95.5%	96.4%	1.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/bundle/params.go	90.6%	92.0%	1.4
pkg/resolution/resolver/bundle/resolver.go	95.5%	96.3%	0.8

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[QuanZhang-William]

Please add action required in the release note. Otherwise lgtm!

[QuanZhang-William]

/assign

[QuanZhang-William]

/lgtm