Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @jeromeJu as a pipelines maintainer #7327

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add @jeromeJu as a pipelines maintainer #7327

merged 1 commit into from
Nov 27, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Nov 2, 2023 •
edited
Loading

Changes

Jerome has been consistently contributing to pipelines for a long while now. He drove much of the long and complicated v1 CRD migration in addition to his recent work around feature flags and software versioning. Along the way, he has racked up well over a 100+ reviews:

https://github.com/tektoncd/pipeline/pulls?q=is%3Apr++reviewed-by%3AJeromeJu+-author%3AJeromeJu+

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@dibyom
Add @JeromeJu as a pipelines maintainer
a38c5c0 
Jerome has been consistently contributing to pipelines for a long while now. He drove much of the long and complicated v1 CRD migration in addition to his recent work around feature flags and software versioning. Along the way, he has racked up well over a 100+ reviews:

https://github.com/tektoncd/pipeline/pulls?q=is%3Apr++reviewed-by%3AJeromeJu+-author%3AJeromeJu+
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 2, 2023
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
@dibyom dibyom marked this pull request as ready for review November 2, 2023 20:00
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@dibyom
Copy link
Member Author

dibyom commented Nov 2, 2023

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 2, 2023
@dibyom
Copy link
Member Author

dibyom commented Nov 2, 2023

/assign @tektoncd/core-maintainers

@chitrangpatel
Copy link
Contributor

chitrangpatel commented Nov 2, 2023 •
edited
Loading

/approve

Thanks for all your work @JeromeJu 🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
Yongxuanzhang
Yongxuanzhang approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

jerop
jerop approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations @JeromeJu 🎉

/meow

@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

Congratulations @JeromeJu 🎉

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester
vdemeester approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

afrittoli
afrittoli reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
🎉

pritidesai
pritidesai approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @JeromeJu, thank you for all the hard work 🙏

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, chitrangpatel, jerop, pritidesai, vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,afrittoli,chitrangpatel,jerop,pritidesai,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented Nov 27, 2023

Congratulations @JeromeJu 👏🏾

/lgtm
/woof

@tekton-robot
Copy link
Collaborator

@jerop: dog image

In response to this:

Congratulations @JeromeJu 👏🏾

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@tekton-robot tekton-robot merged commit c978b70 into main Nov 27, 2023
8 checks passed
@dibyom dibyom deleted the dibyom-patch-2 branch November 27, 2023 22:59
dibyom added a commit that referenced this pull request Nov 29, 2023
@dibyom
Add @JeromeJu as a pipeline maintainer
0590b62 
Jerome was added as a maintainer in #7327
@dibyom dibyom mentioned this pull request Nov 29, 2023
Closed
7 tasks
dibyom added a commit to tektoncd/community that referenced this pull request Nov 29, 2023
@dibyom
Add JeromeJu as a pipelines maintaner
851c241 
Jerome was added as a maintainer in tektoncd/pipeline#7327
dibyom added a commit to tektoncd/community that referenced this pull request Nov 29, 2023
@dibyom
Add JeromeJu as a pipelines maintainer
ef03bfd 
Jerome was added as a maintainer in tektoncd/pipeline#7327
@dibyom dibyom mentioned this pull request Nov 29, 2023
Merged
tekton-robot pushed a commit to tektoncd/community that referenced this pull request Nov 30, 2023
@dibyom @tekton-robot
Add JeromeJu as a pipelines maintainer
ca54d38 
Jerome was added as a maintainer in tektoncd/pipeline#7327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@jerop jerop jerop approved these changes

@pritidesai pritidesai pritidesai approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dibyom @tekton-robot @chitrangpatel @jerop @vdemeester @pritidesai @afrittoli @Yongxuanzhang