Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move getFeatureFlagsBaseOnAPIFlag from custom_task_test to another file #7313

Closed
wants to merge 0 commits into from
Closed

fix: move getFeatureFlagsBaseOnAPIFlag from custom_task_test to another file #7313

wants to merge 0 commits into from

Conversation

Dhruval7878
Copy link
Contributor

@Dhruval7878 Dhruval7878 commented Oct 30, 2023 •
edited
Loading

fixes #7269

/kind cleanup

Changes

Changed the location of function and removed some imports.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 30, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2023
@tekton-robot
Copy link
Collaborator

Hi @Dhruval7878. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot requested review from abayer and jerop October 30, 2023 19:28
@Dhruval7878 Dhruval7878 changed the title fix: move getFeatureFlagsBaseOnAPIFlag from custom_task_test to another file #7269 fix: move getFeatureFlagsBaseOnAPIFlag from custom_task_test to another file Oct 30, 2023
jerop
jerop reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@jerop
Copy link
Member

jerop commented Nov 3, 2023

@Dhruval7878 thank you for the contribution and welcome to Tekton

/meow

Please sign the CLA 🙏🏾

@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

@Dhruval7878 thank you for the contribution and welcome to Tekton

/meow

Please sign the CLA 🙏🏾

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dhruval7878
Copy link
Contributor Author

@jerop Hey, I've just signed the CLA.

@Dhruval7878
Copy link
Contributor Author

Hey !!
What's the status of my PR ?

@Dhruval7878
Copy link
Contributor Author

Hey !! What's the status of my PR ?

@jerop

khrm
khrm reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2023
khrm
khrm reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@Dhruval7878
Copy link
Contributor Author

/retest-required

@Dhruval7878
Copy link
Contributor Author

I'm facing issues with this task, and I'm not sure why it's failing. Any assistance or guidance would be greatly appreciated.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@tekton-robot
Copy link
Collaborator

@Dhruval7878: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerop jerop added this to the Pipelines v0.54 milestone Nov 9, 2023
@Yongxuanzhang
Copy link
Member

/assign

@Yongxuanzhang
Copy link
Member

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

@Dhruval7878
Copy link
Contributor Author

Dhruval7878 commented Nov 9, 2023 •
edited
Loading

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

Sure, but I would like to know why I'm not assignee any longer?

I'm newbie to such things and I would really appreciate if you help me to be on the trail.

@Yongxuanzhang
Copy link
Member

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

Sure, but I would like to know why I'm not assignee any longer?

I'm newbie to such things and I would really appreciate if you help me to be on the trail.

You're assignee of this issue: #7269
The assignee of this PR is the one who's responsible for reviewing it

@Dhruval7878
Copy link
Contributor Author

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

Sure, but I would like to know why I'm not assignee any longer?
I'm newbie to such things and I would really appreciate if you help me to be on the trail.

You're assignee of this issue: #7269 The assignee of this PR is the one who's responsible for reviewing it

okay I got it
So help me , like how to rebase this PR ..

@Yongxuanzhang
Copy link
Member

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

Sure, but I would like to know why I'm not assignee any longer?
I'm newbie to such things and I would really appreciate if you help me to be on the trail.

You're assignee of this issue: #7269 The assignee of this PR is the one who's responsible for reviewing it

okay I got it So help me , like how to rebase this PR ..

Usually you need to create another branch in your forked reop: https://github.com/Dhruval7878/pipeline
And your forked main branch can sync with upstream main. Then you can rebase your working branch with:
git rebase -i main

@Yongxuanzhang
Copy link
Member

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

Sure, but I would like to know why I'm not assignee any longer?
I'm newbie to such things and I would really appreciate if you help me to be on the trail.

You're assignee of this issue: #7269 The assignee of this PR is the one who's responsible for reviewing it

okay I got it So help me , like how to rebase this PR ..

You could search some basic git commands to get familiar with them, and learn how to use

@Dhruval7878
Copy link
Contributor Author

Hi @Dhruval7878 could you rebase the PR? I will help to approve it

Sure, but I would like to know why I'm not assignee any longer?
I'm newbie to such things and I would really appreciate if you help me to be on the trail.

You're assignee of this issue: #7269 The assignee of this PR is the one who's responsible for reviewing it

okay I got it So help me , like how to rebase this PR ..

Usually you need to create another branch in your forked reop: https://github.com/Dhruval7878/pipeline And your forked main branch can sync with upstream main. Then you can rebase your working branch with: git rebase -i main

oke thankss !!

@Dhruval7878 Dhruval7878 closed this Nov 9, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@khrm khrm khrm left review comments

@abayer abayer Awaiting requested review from abayer

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.

move getFeatureFlagsBaseOnAPIFlag from custom_task_test to another file
5 participants
@Dhruval7878 @tekton-robot @jerop @Yongxuanzhang @khrm