Add a simple HTTP resolver #7250

chmouel · 2023-10-20T16:52:26Z

This adds a simple HTTP resolver that can fetch a file from a remote HTTP(S) URL.

Only fetch timeout configuration for now is supported.

This is kept simple for now, and does not support any kind of HTTP authentication, custom TLS or any other features. Something we can improve on later.

Fixes #6920

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

A new HTTP resolver is now available, it will let you resolve a http(s) URL to fetch a task or pipeline from.

/kind feature

chmouel · 2023-10-20T16:54:20Z

/kind feature
/retest

tekton-robot · 2023-10-20T17:03:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	75.0%

tekton-robot · 2023-10-20T17:04:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	75.0%

chmouel · 2023-10-20T17:06:45Z

/test pull-tekton-pipeline-beta-integration-tests

(seems like a fluke of kind)

tekton-robot · 2023-10-20T17:07:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	75.0%

tekton-robot · 2023-10-21T15:21:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-21T15:22:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-24T14:22:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-24T14:25:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

docs/http-resolver.md

jerop

please add an example which would also serve as an e2e test

example: https://github.com/tektoncd/pipeline/blob/main/examples/v1/pipelineruns/beta/git-resolver.yaml

tekton-robot · 2023-10-25T13:51:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

chmouel · 2023-10-25T13:57:04Z

/retest

tekton-robot · 2023-10-25T13:57:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

Yongxuanzhang

Thanks! Just have some minor questions.
Shall we create an issue to track potential future work as you mentioned in the pr description?

pkg/resolution/resolver/http/resolver.go

chmouel · 2023-10-26T07:54:00Z

Shall we create an issue to track potential future work as you mentioned in the pr description?

thanks for the review, yes i am planning to fill/tackle those issues when this is merged !

tekton-robot · 2023-10-26T08:07:38Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-26T08:08:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-26T08:10:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Yongxuanzhang · 2023-10-26T15:20:51Z

Is it possible that we add an example as @jerop suggested, before we merge this PR? 🙏

chmouel · 2023-10-26T16:25:38Z

@Yongxuanzhang I didn't see @jerop comment, thanks!

I just pushed it!

Yongxuanzhang · 2023-10-26T16:26:43Z

@Yongxuanzhang I didn't see @jerop comment, thanks!

I just pushed it!

Thanks!
/lgtm

tekton-robot · 2023-10-26T16:31:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-26T16:33:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

This adds a simple HTTP resolver that can fetch a file from a remote HTTP(S) URL. Only fetch timeout configuration for now is supported. This is kept simple for now, and does not support any kind of HTTP authentication, custom TLS or any other features. Something we can improve on later. Signed-off-by: Chmouel Boudjnah <[email protected]>

chmouel · 2023-10-26T18:26:13Z

The CI failure was a yaml whitespace errors 🍤


./examples/v1/pipelineruns/beta/http-resolver.yaml
  12:18     error    trailing spaces  (trailing-spaces)

tekton-robot · 2023-10-26T18:32:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-26T18:33:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

tekton-robot · 2023-10-26T18:36:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/resolver/feature_flags.go	87.0%	84.0%	-3.0
pkg/resolution/resolver/http/resolver.go	Do not exist	92.5%

Yongxuanzhang · 2023-10-26T19:59:16Z

/lgtm

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2023

tekton-robot requested review from abayer and afrittoli October 20, 2023 16:52

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Oct 20, 2023

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 20, 2023

chmouel force-pushed the add-a-simple-http-resolver branch from ba9d269 to 9bd4350 Compare October 20, 2023 16:57

chmouel force-pushed the add-a-simple-http-resolver branch from 9bd4350 to 032f274 Compare October 21, 2023 15:14

chmouel force-pushed the add-a-simple-http-resolver branch from 032f274 to e5fffe5 Compare October 24, 2023 14:15

jerop reviewed Oct 24, 2023

View reviewed changes

docs/http-resolver.md Outdated Show resolved Hide resolved

jerop added this to the Pipelines v0.54 milestone Oct 24, 2023

jerop reviewed Oct 24, 2023

View reviewed changes

chmouel force-pushed the add-a-simple-http-resolver branch from e5fffe5 to 3c08ba9 Compare October 25, 2023 13:44

Yongxuanzhang reviewed Oct 25, 2023

View reviewed changes

pkg/resolution/resolver/http/resolver.go Outdated Show resolved Hide resolved

pkg/resolution/resolver/http/resolver.go Outdated Show resolved Hide resolved

chmouel force-pushed the add-a-simple-http-resolver branch from 3c08ba9 to 6ca1535 Compare October 26, 2023 08:00

vdemeester approved these changes Oct 26, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023

chmouel force-pushed the add-a-simple-http-resolver branch from 6ca1535 to 47754c2 Compare October 26, 2023 16:24

tekton-robot assigned Yongxuanzhang Oct 26, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023

chmouel force-pushed the add-a-simple-http-resolver branch from 47754c2 to de2f5d8 Compare October 26, 2023 18:25

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023

chmouel force-pushed the add-a-simple-http-resolver branch from de2f5d8 to a292732 Compare October 26, 2023 18:25

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023

tekton-robot merged commit 9f8fbb4 into tektoncd:main Oct 26, 2023
2 checks passed

chmouel deleted the add-a-simple-http-resolver branch October 26, 2023 21:41

This was referenced Oct 27, 2023

Custom HTTPS certificate for HTTP URL resolver #7295

Open

Username/Password support in HTTP Resolver #7296

Closed

Custom proxy support for HTTP URL resolver #7297

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a simple HTTP resolver #7250

Add a simple HTTP resolver #7250

chmouel commented Oct 20, 2023 •

edited

Loading

chmouel commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

chmouel commented Oct 20, 2023 •

edited

Loading

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 21, 2023

tekton-robot commented Oct 21, 2023

tekton-robot commented Oct 24, 2023

tekton-robot commented Oct 24, 2023

jerop left a comment

tekton-robot commented Oct 25, 2023

chmouel commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

Yongxuanzhang left a comment

chmouel commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

Yongxuanzhang commented Oct 26, 2023 •

edited

Loading

chmouel commented Oct 26, 2023 •

edited

Loading

Yongxuanzhang commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

chmouel commented Oct 26, 2023 •

edited

Loading

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

Yongxuanzhang commented Oct 26, 2023

Add a simple HTTP resolver #7250

Add a simple HTTP resolver #7250

Conversation

chmouel commented Oct 20, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

chmouel commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 20, 2023

chmouel commented Oct 20, 2023 • edited Loading

tekton-robot commented Oct 20, 2023

tekton-robot commented Oct 21, 2023

tekton-robot commented Oct 21, 2023

tekton-robot commented Oct 24, 2023

tekton-robot commented Oct 24, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 25, 2023

chmouel commented Oct 25, 2023

tekton-robot commented Oct 25, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

chmouel commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

Yongxuanzhang commented Oct 26, 2023 • edited Loading

chmouel commented Oct 26, 2023 • edited Loading

Yongxuanzhang commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

chmouel commented Oct 26, 2023 • edited Loading

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

tekton-robot commented Oct 26, 2023

Yongxuanzhang commented Oct 26, 2023

chmouel commented Oct 20, 2023 •

edited

Loading

chmouel commented Oct 20, 2023 •

edited

Loading

Yongxuanzhang commented Oct 26, 2023 •

edited

Loading

chmouel commented Oct 26, 2023 •

edited

Loading

chmouel commented Oct 26, 2023 •

edited

Loading