Fix typos in DEVELOPMENT.md file #7179

shankarpentyala07 · 2023-10-05T20:44:01Z

Changes

In DEVELOPMENT.md file , to configure upstream optional , while set up a fork , the instructions throws an error when used in zsh shell , because of # symbol not found.
In setup cluster of type kind , the word kind is in Camel case Kind , changed it to lower case kind
The update or add new crd types in Iterating on code changes section, doesn't navigate and has been corrected.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

linux-foundation-easycla · 2023-10-05T20:44:08Z

❌ - login: @shankar-pentyala / name: shankar pentyala . The commit (e3d1397) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

tekton-robot · 2023-10-05T20:44:11Z

Hi @shankarpentyala07. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shankarpentyala07 · 2023-10-05T20:45:54Z

/kind documentation

Yongxuanzhang · 2023-10-06T03:07:40Z

/ok-to-test

Yongxuanzhang

could you squash your commits into 1? 🙏

Yongxuanzhang · 2023-10-06T03:10:56Z

DEVELOPMENT.md

        git remote add upstream [email protected]:tektoncd/pipeline.git
+        ```

-        # Optional: Prevent accidental pushing of commits by changing the upstream URL to `no_push`
+    3. Optional: Prevent accidental pushing of commits by changing the upstream URL to `no_push`
+        ```shell


Why need this change

Thanks for review
Prior , it is as below:

When copied and pasted in zsh shell , below error is thrown.

# Optional: Prevent accidental pushing of commits by changing the upstream URL to `no_push` git remote set-url --push upstream no_push zsh: command not found: no_push zsh: command not found: #

When optional section is moved to new line as below, the issue is not seen

Yongxuanzhang · 2023-10-06T03:13:48Z

DEVELOPMENT.md

@@ -271,9 +273,9 @@ The recommended minimum development configuration is:
  - 8 GB of (actual or virtualized) platform memory
 - Node autoscaling, up to 3 nodes

-#### Using [KinD](https://kind.sigs.k8s.io/)


I remember this was because it stands for K8s in Docker, but I'm ok with either

Yongxuanzhang · 2023-10-06T03:15:51Z

DEVELOPMENT.md

@@ -353,7 +355,7 @@ While iterating on code changes to the project, you may need to:
    - Update your (external) dependencies with: `./hack/update-deps.sh`
    - Update your type definitions with: `./hack/update-codegen.sh`
    -  Update your OpenAPI specs with: `./hack/update-openapigen.sh`
-1. Update or [add new CRD types](#adding-new-types) as needed
+1. Update or [add new CRD types](#adding-new-crd-types) as needed


shankarpentyala07 · 2023-10-12T18:37:15Z

could you squash your commits into 1? 🙏

@Yongxuanzhang I have squashed the commits , Could you please review.

Yongxuanzhang · 2023-10-12T18:53:57Z

could you squash your commits into 1? 🙏

@Yongxuanzhang I have squashed the commits , Could you please review.

Could you sign the CLA? I remember there is a button there and you need to click it?

spzala · 2023-10-12T21:51:47Z

CLA approval in progress. Thanks!

In optional configuring upstream to no_push in Setup a fork section ,the content was modified to work in zsh shell In Setup a Kubernetes cluster using kind , it was mentioned as Kind in camelcase , changed it to lower case

pritidesai · 2023-10-13T00:55:26Z

Closing and reopening the PR to test the CLA 🙃

pritidesai

Welcome to the Tekton Community @shankarpentyala07! Thanks for all the changes 👍

tekton-robot · 2023-10-13T01:00:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pritidesai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shankarpentyala07 · 2023-10-13T16:18:45Z

Welcome to the Tekton Community @shankarpentyala07! Thanks for all the changes 👍

Thanks Preeti for the welcome & all your help,I am hoping to be an active contributor to the project.

Yongxuanzhang · 2023-10-13T18:35:53Z

/lgtm

pritidesai · 2023-10-16T18:27:09Z

Closing and reopening the PR to trigger EasyCLA!

Yongxuanzhang · 2023-10-18T17:51:14Z

@shankarpentyala07 could you double check if you have signed the CLA? Thanks!

shankarpentyala07 · 2023-10-18T18:00:54Z

Thanks @Yongxuanzhang .yes - I did try few times.

Yongxuanzhang · 2023-10-18T18:56:15Z

Thanks @Yongxuanzhang .yes - I did try few times.

Are you using different accounts to commit and open the PR?

shankarpentyala07 · 2023-10-18T19:27:34Z

Thanks @Yongxuanzhang for identifying the issue.
Found that, My local gitconfig has IBM org email and when opening the pull request , I was opening from my public Github.Both email id has been approved in the CLA list.

I have opened a new pull request with same changes and CLA passed : #7233. Shall I go ahead and close this pull request and use the new pull request for the changes.

Yongxuanzhang · 2023-10-18T19:28:59Z

Thanks @Yongxuanzhang for identifying the issue. Found that, My local gitconfig has IBM org email and when opening the pull request , I was opening from my public Github.Both email id has been approved in the CLA list.

I have opened a new pull request with same changes and CLA passed : #7233. Shall I go ahead and close this pull request and use the new pull request for the changes.

Yeah, that's fine

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 5, 2023

tekton-robot requested review from afrittoli and Yongxuanzhang October 5, 2023 20:44

tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2023

shankarpentyala07 changed the title ~~Issue 7013~~ Fix typos in DEVELOPMENT.md file Oct 5, 2023

tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 5, 2023

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2023

Yongxuanzhang reviewed Oct 6, 2023

View reviewed changes

shankarpentyala07 force-pushed the issue_7013 branch 2 times, most recently from ca0d793 to b847c6b Compare October 6, 2023 07:22

Fix navigation to add new crd types in development.md

e3d1397

In optional configuring upstream to no_push in Setup a fork section ,the content was modified to work in zsh shell In Setup a Kubernetes cluster using kind , it was mentioned as Kind in camelcase , changed it to lower case

shankarpentyala07 force-pushed the issue_7013 branch from b847c6b to e3d1397 Compare October 12, 2023 22:17

pritidesai closed this Oct 13, 2023

pritidesai reopened this Oct 13, 2023

pritidesai approved these changes Oct 13, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023

tekton-robot assigned Yongxuanzhang Oct 13, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023

pritidesai closed this Oct 16, 2023

pritidesai reopened this Oct 16, 2023

shankarpentyala07 closed this Oct 18, 2023

shankarpentyala07 reopened this Oct 18, 2023

shankarpentyala07 closed this Oct 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typos in DEVELOPMENT.md file #7179

Fix typos in DEVELOPMENT.md file #7179

shankarpentyala07 commented Oct 5, 2023 •

edited by pritidesai

Loading

linux-foundation-easycla bot commented Oct 5, 2023 •

edited

Loading

tekton-robot commented Oct 5, 2023

shankarpentyala07 commented Oct 5, 2023

Yongxuanzhang commented Oct 6, 2023

Yongxuanzhang left a comment

Yongxuanzhang Oct 6, 2023

shankarpentyala07 Oct 6, 2023

Yongxuanzhang Oct 6, 2023

Yongxuanzhang Oct 6, 2023

shankarpentyala07 commented Oct 12, 2023

Yongxuanzhang commented Oct 12, 2023 •

edited

Loading

spzala commented Oct 12, 2023

pritidesai commented Oct 13, 2023

pritidesai left a comment

tekton-robot commented Oct 13, 2023

shankarpentyala07 commented Oct 13, 2023

Yongxuanzhang commented Oct 13, 2023

pritidesai commented Oct 16, 2023

Yongxuanzhang commented Oct 18, 2023

shankarpentyala07 commented Oct 18, 2023

Yongxuanzhang commented Oct 18, 2023

shankarpentyala07 commented Oct 18, 2023

Yongxuanzhang commented Oct 18, 2023

Fix typos in DEVELOPMENT.md file #7179

Fix typos in DEVELOPMENT.md file #7179

Conversation

shankarpentyala07 commented Oct 5, 2023 • edited by pritidesai Loading

Changes

Submitter Checklist

Release Notes

linux-foundation-easycla bot commented Oct 5, 2023 • edited Loading

tekton-robot commented Oct 5, 2023

shankarpentyala07 commented Oct 5, 2023

Yongxuanzhang commented Oct 6, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

Yongxuanzhang Oct 6, 2023

Choose a reason for hiding this comment

shankarpentyala07 Oct 6, 2023

Choose a reason for hiding this comment

Yongxuanzhang Oct 6, 2023

Choose a reason for hiding this comment

Yongxuanzhang Oct 6, 2023

Choose a reason for hiding this comment

shankarpentyala07 commented Oct 12, 2023

Yongxuanzhang commented Oct 12, 2023 • edited Loading

spzala commented Oct 12, 2023

pritidesai commented Oct 13, 2023

pritidesai left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 13, 2023

shankarpentyala07 commented Oct 13, 2023

Yongxuanzhang commented Oct 13, 2023

pritidesai commented Oct 16, 2023

Yongxuanzhang commented Oct 18, 2023

shankarpentyala07 commented Oct 18, 2023

Yongxuanzhang commented Oct 18, 2023

shankarpentyala07 commented Oct 18, 2023

Yongxuanzhang commented Oct 18, 2023

shankarpentyala07 commented Oct 5, 2023 •

edited by pritidesai

Loading

linux-foundation-easycla bot commented Oct 5, 2023 •

edited

Loading

Yongxuanzhang commented Oct 12, 2023 •

edited

Loading