Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @Yongxuanzhang as a pipelines maintainer #7168

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add @Yongxuanzhang as a pipelines maintainer #7168

merged 1 commit into from
Oct 5, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 2, 2023 •
edited
Loading

Changes

@Yongxuanzhang has been a consistent contributor to pipelines for a long time now and has worked on a number of big features such as trusted resources and array parameters. He has also reviewed 130+ PRs and meets all the other criteria for being a maintainer.

Reviews: https://github.com/search?q=-author%3Ayongxuanzhang+repo%3Atektoncd%2Fpipeline+reviewed-by%3Ayongxuanzhang+type%3Apr&type=pullrequests

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@dibyom
Add @Yongxuanzhang as a pipelines maintainer
ddcc984 
@Yongxuanzhang has been a consistent contributor to pipelines for a long time now and has worked on a number of big features such as trusted resources and array parameters. He has also reviewed 130+ PRs and meets all the other criteria for being a maintainer.

Reviews: https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+yongxuanzhang+is%3Aclosed
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 2, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2023
@dibyom
Copy link
Member Author

dibyom commented Oct 2, 2023

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 2, 2023
@dibyom
Copy link
Member Author

dibyom commented Oct 2, 2023

/assign @tektoncd/core-maintainers

vdemeester
vdemeester approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
afrittoli
afrittoli reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉 🤖 🐱
/approve

jerop
jerop approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

Thank you @Yongxuanzhang for all your hard work and very excited to have you join the maintainer squad 🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, jerop, pritidesai, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,jerop,pritidesai,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tektoncd tektoncd deleted a comment from tekton-robot Oct 4, 2023
@wlynch
Copy link
Member

wlynch commented Oct 5, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@Yongxuanzhang
Copy link
Member

Thank you all!! ❤️

@chuangw6
Copy link
Member

chuangw6 commented Oct 5, 2023

/lgtm

Thank you @Yongxuanzhang for all your contributions!!!

@chuangw6
Copy link
Member

chuangw6 commented Oct 5, 2023

/meow

@tekton-robot
Copy link
Collaborator

@chuangw6: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chuangw6
Copy link
Member

chuangw6 commented Oct 5, 2023

/meow

@tekton-robot
Copy link
Collaborator

@chuangw6: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 803e920 into main Oct 5, 2023
2 checks passed
@dibyom dibyom deleted the dibyom-patch-1 branch October 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@jerop jerop jerop approved these changes

@pritidesai pritidesai pritidesai approved these changes

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@pritidesai pritidesai

@wlynch wlynch

@afrittoli afrittoli

@jerop jerop

@chuangw6 chuangw6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dibyom @tekton-robot @pritidesai @wlynch @Yongxuanzhang @chuangw6 @vdemeester @afrittoli @jerop