Skip to content

Commit

Permalink
#7617 support k8s native sidecar
Browse files Browse the repository at this point in the history
  • Loading branch information
kgcarr committed Jun 14, 2024
1 parent 013b021 commit f154502
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/reconciler/taskrun/taskrun.go
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ func (c *Reconciler) durationAndCountMetrics(ctx context.Context, tr *v1.TaskRun
}

func (c *Reconciler) stopSidecars(ctx context.Context, tr *v1.TaskRun) error {

// Check if current k8s version is less than 1.29
// Since Kubernetes Major version cannot be 0 and if it's 2 then sidecar will be in
// we are only concerned about major version 1 and if the minor is less than 29 then
Expand Down Expand Up @@ -353,7 +352,6 @@ func (c *Reconciler) stopSidecars(ctx context.Context, tr *v1.TaskRun) error {
logger.Errorf("Error stopping sidecars for TaskRun %q: %v", tr.Name, err)
tr.Status.MarkResourceFailed(v1.TaskRunReasonStopSidecarFailed, err)
}

}
return nil
}
Expand Down

0 comments on commit f154502

Please sign in to comment.