Skip to content

Commit

Permalink
Improve gha k8s e2e tests names
Browse files Browse the repository at this point in the history
Change the job names so that the names do not need to changes
when things like k8s versions change. This helps with keeping
the prow/tide configuration of required jobs fixed.

Signed-off-by: Andrea Frittoli <[email protected]>
  • Loading branch information
afrittoli committed Dec 9, 2024
1 parent d306d64 commit b3e9ad0
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/chatops_retest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,4 @@ jobs:
token: ${{ secrets.CHATOPS_TOKEN }}
repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
reaction-type: hooray
reactions: hooray
25 changes: 18 additions & 7 deletions .github/workflows/e2e-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,27 @@ jobs:
strategy:
fail-fast: false # Keep running if one leg fails.
matrix:
k8s-version:
- v1.28.x
- v1.29.x
k8s-name:
- k8s-oldest
- k8s-plus-one

feature-flags:
- prow
- prow-beta
- prow-alpha
- stable
- beta
- alpha
# - prow-feature-flags - this is tested today as a periodic job, but we could integrate it here

include:
- k8s-name: k8s-oldest
k8s-version: v1.28.x
- k8s-name: k8s-plus-one
k8s-version: v1.29.x
- feature-flags: stable
env-file: prow
- feature-flags: alpha
env-file: prow-alpha
- feature-flags: beta
env-file: prow-beta
env:
GOPATH: ${{ github.workspace }}
GO111MODULE: on
Expand Down Expand Up @@ -73,7 +84,7 @@ jobs:
--nodes 3 \
--k8s-version ${{ matrix.k8s-version }} \
--e2e-script ./test/e2e-tests.sh \
--e2e-env ./test/e2e-tests-kind-${{ matrix.feature-flags }}.env
--e2e-env ./test/e2e-tests-kind-${{ matrix.env-file }}.env
- name: Upload test results
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit b3e9ad0

Please sign in to comment.