Skip to content

Commit

Permalink
Refacor install_pipeline_crd SYSTEM_NAMESPACE env setup
Browse files Browse the repository at this point in the history
This commit refactors the setup for `SYSTEM_NAMESPACE` which was
previously set in the `install_pipeline_crd` helper function. But it
should not be necessary to be part of the pipeline installation instead
it is an env setup. This helps resolve the issue where we could not
run tests before installing the current version of pipeline CRDs.
  • Loading branch information
JeromeJu authored and tekton-robot committed Mar 6, 2024
1 parent c93843d commit 742292d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ function install_pipeline_crd() {
verify_pipeline_installation
verify_resolvers_installation
verify_log_access_enabled

export SYSTEM_NAMESPACE=tekton-pipelines
}

# Install the Tekton pipeline crd based on the release number
Expand Down
2 changes: 2 additions & 0 deletions test/e2e-tests-upgrade.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ set -o nounset

export SYSTEM_NAMESPACE=tekton-pipelines

export SYSTEM_NAMESPACE=tekton-pipelines

# First, we will verify if Scenario 1 works.
# Install the previous release.
header "Install the previous release of Tekton pipeline $PREVIOUS_PIPELINE_VERSION"
Expand Down
1 change: 1 addition & 0 deletions test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ fi
header "Setting up environment"

install_pipeline_crd
export SYSTEM_NAMESPACE=tekton-pipelines

failed=0

Expand Down

0 comments on commit 742292d

Please sign in to comment.