kind/fix: allow-pipelinetask-execution-evaluation v1beta1 src

tektoncd · Jan 16, 2024 · 5340579 · 5340579
1 parent 411af65
commit 5340579
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pkg/apis/pipeline/v1beta1/when_types.go b/pkg/apis/pipeline/v1beta1/when_types.go
@@ -105,10 +105,7 @@ type WhenExpressions []WhenExpression
 // if the Task should be skipped.
 func (wes WhenExpressions) AllowsExecution(evaluatedCEL map[string]bool) bool {
 	for _, we := range wes {
-		if we.CEL != "" {
-			return evaluatedCEL[we.CEL]
-		}
-		if !we.isTrue() {
+		if !we.isTrue() || (we.CEL != "" && !evaluatedCEL[we.CEL]) {
 			return false
 		}
 	}