Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config leader election configmap name #1881

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

piyush-garg
Copy link
Contributor

This will update the name of the configmap responsible for controller to contain config of leader election

Based on the PR on pipeline upstream
tektoncd/pipeline#7014

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fix config leader election configmap name

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 28, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2023
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
This will update the name of the configmap responsible for
controller to contain config of leader election

Based on the PR on pipeline upstream
tektoncd/pipeline#7014
@piyush-garg piyush-garg force-pushed the fix_cont_elec_config_name branch from 67d81c3 to 7d03077 Compare November 28, 2023 03:18
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@piyush-garg
Copy link
Contributor Author

/cherry-pick release-v0.69.x

@tekton-robot
Copy link
Contributor

@piyush-garg: once the present PR merges, I will cherry-pick it on top of release-v0.69.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.69.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkandasa
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@tekton-robot tekton-robot merged commit dbd0664 into tektoncd:main Nov 28, 2023
2 checks passed
@tekton-robot
Copy link
Contributor

@piyush-garg: new pull request created: #1882

In response to this:

/cherry-pick release-v0.69.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants