-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buildType for Chains format slsa/v2alpha2 (SLSAv1.0 predicate). #906
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4333990
to
aaaa781
Compare
docs/buildtype/buildtype-v2.md
Outdated
# Description | ||
|
||
``` | ||
"buildType": "https://tekton.dev/docs/chains/buildtype-v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right build type?
I don't know if we should be pointing to /docs/
page - I'd prefer to carve out a more dedicated space e.g. https://tekton.dev/predicate/chains/run/v2alpha1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This url is what would appear if we simply merged this doc as is. This is what the Tekton Website would point to. I can certainly work towards making changes in the Tekton website as well such that the url is what we desire.
Let me start by trying to achieve something like this: https://tekton.dev/predicate/chains/run/v2alpha1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now "buildType": "https://tekton.dev/predicate/chains/slsa/v2"
4e0c486
to
0528761
Compare
32647cd
to
5e67cca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @chitrangpatel for writing this up!
This PR adds the build type for the implementation of the SLSA format v2alpha2 as per issue tektoncd#797.
5e67cca
to
92217e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mean to be pedantic but I used your samples as input to test a provenance validator and found a few typos in the json.
Also I should note that I don't believe it is valid for a URI to be relative as in:
"uri": "gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init",
Otherwise this looks good to me.
Thanks for working on adding support for SLSA 1.0!
pulling in suggested changes. Co-authored-by: Arnaud J Le Hors <[email protected]>
Folks, I apologize for not realizing that this was blocked by my (simple) contribution not being covered by my company's CLA. I got this addressed and hope you can proceed with merging this PR. |
Changes
Fixes #890
This PR adds the build type for the implementation of the SLSA format v2alpha2 as per issue #797.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/kind documentation
Looks something like this on locally hosted tekton website: