Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.23 and plumbing vendoring #1284

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update go to 1.23 and plumbing vendoring #1284

merged 1 commit into from
Jan 16, 2025

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Jan 16, 2025 •
edited
Loading

Changes

The vendored version of tektoncd/plumbing is from 2023.
Updating plumbing brings in an update of golang as well to 1.23.

go get github.com/tektoncd/plumbing@f515628dffea46d3a0556b52e19119ba21e9e4ad
go mod tidy
go mod vendor

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 16, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@afrittoli afrittoli force-pushed the update_plumbing_vendoring branch 2 times, most recently from 7836e36 to fa4c1df Compare January 16, 2025 14:54
@tekton-robot
Copy link

@afrittoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-chains-integration-tests fa4c1df link true /test pull-tekton-chains-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester
Copy link
Member

/approve

@afrittoli you might need to rebase.

@afrittoli
Update go to 1.23 and plumbing vendoring
9d4bbcd 
The vendored version of tektoncd/plumbing is from 2023.
Updating plumbing brings in an update of golang as well to 1.23.

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli force-pushed the update_plumbing_vendoring branch from fa4c1df to 9d4bbcd Compare January 16, 2025 18:54
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2025
lcarva
lcarva approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@tekton-robot tekton-robot merged commit d8ec406 into tektoncd:main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrittoli @tekton-robot @vdemeester @lcarva