Initial proposal to create new counters/timeseries to account for tasknames and namespaces #1170

nistar · 2024-07-31T23:02:46Z

Changes

Created new const values for a possible future functionality

We're trying to implement the following solution:

Having some metric statistics on container signing, meaning "this many containers were generated, this many were signed, this many weren't". Having a namespace categorization would be helpful.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tasknames and namespaces

linux-foundation-easycla · 2024-07-31T23:02:49Z

✅ login: nistar / name: Alex Vilensky (b1a8c9e, 9721264, d2c736e, 635bd0f, 7097e28, 9c2aedf, 0790196, 7067f36, 65b92ad, 499ecb0, 1e28bad, 9362db3, 6bc5b00, b664f2a)
❌ The email address for the commit (9060c18, e9054f3, ea89816, cd383dc) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

tekton-robot · 2024-07-31T23:02:55Z

Hi @nistar. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-07-31T23:02:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign chuangw6 after the PR has been reviewed.
You can assign the PR to them by writing /assign @chuangw6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PuneetPunamiya · 2024-08-01T06:33:47Z

@nistar Can you please sign the SLA

PuneetPunamiya · 2024-08-01T06:34:12Z

/ok-to-test

nistar · 2024-08-01T16:12:50Z

/ok-to-test

@nistar Can you please sign the SLA

Done. Please, let me know if I need to provide more info

lcarva · 2024-08-01T18:06:45Z

pkg/chains/constants.go

+	PipelineRunStoredDesc        = "Total number of stored payloads for pipelineruns"
+	PipelineRunMarkedName        = "pipelinerun_marked_signed_total"
+	PipelineRunMarkedDesc        = "Total number of objects marked as signed for pipelineruns"
+	PipelineRunSignedMsg         = "pipelinerun_signed_messages"


How's this different than PipelineRunSignedName ?

Actually, I'm not sure how any of the ones being added are different than the existing ones. What am I missing?

The ones currently used produce totals across the entire cluster. We need a more detailed information, such as a namespace, taskname, success/failure and other kinds of labels attached to the counters. So my proposal is to leave the old ones alone and create a new time series that can be utilized to display info related to individual projects in Grafana or some other tool.

That makes sense. Can we make the name and description indicative of this?

Do we have a naming convention?

Not an official one. I would just like to make it obvious that certain metric is namespace based. Does that make sense?

Does it look ok?

Hi @lcarva do the names look ok to you?

Sorry for the delay! Yes, that looks reasonable. Were you thinking about doing the same for TaskRuns as well?

Yes, just wanted to make small and manageable changes at a time.

tekton-robot · 2024-08-20T23:10:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-08-26T21:37:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-09-11T19:06:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-09-16T21:56:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

nistar · 2024-09-16T21:58:25Z

It looks like we don't honor storage.oci.repository.insecure flag on every execution path and it results in https/http protocol errors when trying to communicate with insecure registries like kind. I've added a few checks to make sure it's implemented. Welcome any comments/suggestions

nistar · 2024-09-17T17:16:27Z

@lcarva @PuneetPunamiya I've modified a couple of files to honor the storage.oci.repository.insecure flag to be able to test with kind registry. What are your thoughts on this?

tekton-robot · 2024-09-17T20:54:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-09-19T17:59:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

lcarva · 2024-09-19T19:18:16Z

@lcarva @PuneetPunamiya I've modified a couple of files to honor the storage.oci.repository.insecure flag to be able to test with kind registry. What are your thoughts on this?

@nistar, I don' think name.Digest queries the registry. Have you actually seen this cause an error?

nistar · 2024-09-19T19:54:13Z

@lcarva @PuneetPunamiya I've modified a couple of files to honor the storage.oci.repository.insecure flag to be able to test with kind registry. What are your thoughts on this?

@nistar, I don' think name.Digest queries the registry. Have you actually seen this cause an error?

@lcarva The code eventually ends up calling Ping:

resulting in "using https with http protocol" error message

lcarva · 2024-09-19T21:05:29Z

@nistar ah! name.NewDigest creates a new object that stores the insecure registry option. This is later used in queries to the registry. Good find!

Could you open a separate PR for that? 🙏

tekton-robot · 2024-09-26T20:02:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-01T04:07:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-02T23:33:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-10T15:52:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-16T02:46:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-22T22:23:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-31T16:24:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	84.6%	76.5%	-8.1

tekton-robot · 2024-10-31T16:24:44Z

@nistar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-chains-unit-tests	`499ecb0`	link	true	`/test pull-tekton-chains-unit-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Initial proposal to create new counters/timeseries to account for

e9054f3

tasknames and namespaces

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024

tekton-robot requested review from chitrangpatel and lcarva July 31, 2024 23:02

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2024

lcarva reviewed Aug 1, 2024

View reviewed changes

Alex Vilensky and others added 5 commits August 1, 2024 13:29

Renamed namespace aware timeseries/counters

cd383dc

Merge branch 'tektoncd:main' into main

7097e28

Merge branch 'tektoncd:main' into main

635bd0f

Merge branch 'tektoncd:main' into main

d2c736e

Added additional namespace aware metrics

9060c18

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2024

Merge branch 'tektoncd:main' into main

b1a8c9e

Merge branch 'tektoncd:main' into main

65b92ad

Honor storage.oci.repository.insecure flag for various code paths

ea89816

Merge branch 'tektoncd:main' into main

9c2aedf

Merge branch 'tektoncd:main' into main

0790196

Merge branch 'tektoncd:main' into main

b664f2a

Merge branch 'tektoncd:main' into main

1e28bad

Merge branch 'tektoncd:main' into main

9721264

Merge branch 'tektoncd:main' into main

6bc5b00

Merge branch 'tektoncd:main' into main

9362db3

Merge branch 'tektoncd:main' into main

7067f36

Merge branch 'tektoncd:main' into main

499ecb0

Initial proposal to create new counters/timeseries to account for tasknames and namespaces #1170

Are you sure you want to change the base?

Initial proposal to create new counters/timeseries to account for tasknames and namespaces #1170

Conversation

nistar commented Jul 31, 2024

Changes

Submitter Checklist

Release Notes

linux-foundation-easycla bot commented Jul 31, 2024 • edited Loading

tekton-robot commented Jul 31, 2024

tekton-robot commented Jul 31, 2024

PuneetPunamiya commented Aug 1, 2024

PuneetPunamiya commented Aug 1, 2024

nistar commented Aug 1, 2024

lcarva Aug 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tekton-robot commented Aug 20, 2024

tekton-robot commented Aug 26, 2024

tekton-robot commented Sep 11, 2024

tekton-robot commented Sep 16, 2024

nistar commented Sep 16, 2024

nistar commented Sep 17, 2024

tekton-robot commented Sep 17, 2024

tekton-robot commented Sep 19, 2024

lcarva commented Sep 19, 2024

nistar commented Sep 19, 2024

lcarva commented Sep 19, 2024

tekton-robot commented Sep 26, 2024

tekton-robot commented Oct 1, 2024

tekton-robot commented Oct 2, 2024

tekton-robot commented Oct 10, 2024

tekton-robot commented Oct 16, 2024

tekton-robot commented Oct 22, 2024

tekton-robot commented Oct 31, 2024

tekton-robot commented Oct 31, 2024

linux-foundation-easycla bot commented Jul 31, 2024 •

edited

Loading

lcarva Aug 1, 2024 •

edited

Loading