Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter layers that used on the current transition #2419

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Sep 23, 2024

Description

On chapter exit transition filter layers that are used on the current transition

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

@josebui josebui self-assigned this Sep 23, 2024
@josebui josebui marked this pull request as ready for review September 23, 2024 16:38
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to add any tests for this?

@josebui
Copy link
Contributor Author

josebui commented Sep 24, 2024

@paulschreiber I was thinking yesterday about that, it might not be that trivial to add test for this since it is tighly linked to the scrollama library, but let me check if I can do something

@josebui josebui force-pushed the fix/same-map-usages branch from 1bfbd0e to 019d6c1 Compare September 26, 2024 16:20
@josebui josebui merged commit 749b10b into main Sep 27, 2024
8 of 9 checks passed
@josebui josebui deleted the fix/same-map-usages branch September 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants