Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shared files layout improvements #1669

Merged
merged 13 commits into from
Mar 27, 2024
Merged

fix: shared files layout improvements #1669

merged 13 commits into from
Mar 27, 2024

Conversation

paulschreiber
Copy link
Member

@paulschreiber paulschreiber commented Mar 25, 2024 •
edited
Loading

Description

  • vertically align file type icon on mobile
  • add space at top of full-screen confirmation dialog
  • prevent share icon from overlapping file name on mobile

Checklist

  • Corresponding issue has been opened
  • Verified on mobile
  • Verified on desktop

Related Issues

Fixes #1659.

@paulschreiber paulschreiber requested a review from knipec March 25, 2024 17:17
knipec
knipec requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@knipec knipec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why your approach for the icon vertical alignment works? I might be missing something.

src/sharedData/components/SharedDataEntryBase.js Outdated Show resolved Hide resolved
src/sharedData/components/SharedDataEntryBase.js Outdated Show resolved Hide resolved
@paulschreiber paulschreiber requested a review from knipec March 25, 2024 20:26
knipec
knipec reviewed Mar 25, 2024
View reviewed changes
src/sharedData/components/SharedFileIcon.js Outdated Show resolved Hide resolved
src/sharedData/components/SharedFileIcon.js Outdated Show resolved Hide resolved
src/sharedData/components/SharedDataEntryBase.js Outdated Show resolved Hide resolved
@paulschreiber paulschreiber requested a review from knipec March 25, 2024 21:35
knipec
knipec approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@knipec knipec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this with me!

src/sharedData/components/SharedFileIcon.js Outdated Show resolved Hide resolved
@paulschreiber paulschreiber merged commit 2eec5ad into main Mar 27, 2024
8 of 9 checks passed
@paulschreiber paulschreiber deleted the fix/files-layout branch April 10, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knipec knipec knipec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertically align the file type icon with top in Shared Files & Links module
2 participants
@paulschreiber @knipec