Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set English and Spanish localization for date and author of shared files #1665

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

knipec
Copy link
Contributor

@knipec knipec commented Mar 22, 2024

Description

Sets localization properly for the date and author string that was hard-coded into the SharedDataEntryBase component (e.g., "Mar 22, 2024, by Carissa Knipe" in English; "22 mar 2024, por Carissa Knipe" in Spanish)

Checklist

  • Strings are localized
  • Verified on mobile
  • Verified on desktop

Related Issues

Fixes #1662

Verification steps

See #1662

@paulschreiber paulschreiber merged commit a65dcde into main Mar 26, 2024
8 of 9 checks passed
knipec added a commit that referenced this pull request Mar 26, 2024
…ncorrectly (#1692)

I incorrectly resolved a merge conflict in #1665.
For a minute the order of shared file info was (incorrectly): file type, then date and user, then file size.
This change returns the order to: file type, then file size, then date and user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization missing in shared files and links for "<date>, by <author>"
3 participants