Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set English and Spanish localization for date and author of shared files #1664

Closed
wants to merge 82 commits into from

Conversation

knipec
Copy link
Contributor

@knipec knipec commented Mar 22, 2024

Description

Sets localization properly for the date and author string that was hard-coded into the SharedDataEntryBase component (e.g., "Mar 22, 2024, by Carissa Knipe" in English; "22 mar 2024, por Carissa Knipe" in Spanish)

Checklist

  • Strings are localized
  • Verified on mobile
  • Verified on desktop

Related Issues

Fixes #1662

Verification steps

See #1662

josebui and others added 30 commits February 28, 2024 14:50
…on betwen fetching shared resources and fetching data entries
    fix: rename SENTRY_DSN environment variable to REACT_APP_SENTRY_DSN
    fix: update sentry config
    chore: gitignore sentry CLI config
    chore: update sentry CLI
knipec and others added 28 commits March 20, 2024 15:13
# Conflicts:
#	src/navigation/navigationContext.js
@knipec knipec closed this Mar 22, 2024
@knipec
Copy link
Contributor Author

knipec commented Mar 22, 2024

Ignore this; I incorrectly created my branch off of staging instead of main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization missing in shared files and links for "<date>, by <author>"
4 participants