-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set English and Spanish localization for date and author of shared files #1664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on betwen fetching shared resources and fetching data entries
fix: rename SENTRY_DSN environment variable to REACT_APP_SENTRY_DSN fix: update sentry config chore: gitignore sentry CLI config chore: update sentry CLI
# Conflicts: # src/navigation/navigationContext.js
Ignore this; I incorrectly created my branch off of staging instead of main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets localization properly for the date and author string that was hard-coded into the SharedDataEntryBase component (e.g., "Mar 22, 2024, by Carissa Knipe" in English; "22 mar 2024, por Carissa Knipe" in Spanish)
Checklist
Related Issues
Fixes #1662
Verification steps
See #1662