fix: use anchor for map location dialog, compensate for padding issue #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good to me. Waiting for @josebui's thoughts on if this approach makes sense.
josebui
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dialog box was set to not use an 'anchor' for its help icon, which caused it to show in the middle of the screen. I set the component to use default anchor element behavior. This caused a styling issue as a side-effect because non-anchored help boxes are styled differently than anchored ones. I compensated by changing the content to use equivalent styling.
Checklist
Related Issues
Fixes #1477
Verification steps
Begin creating a new story map. Click 'set map location' and verify that the info dialog is displayed at the expected position with the expected spacing.