Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fallback page title when first name is missing #1573

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix: add fallback page title when first name is missing #1573

merged 4 commits into from
Mar 7, 2024

Conversation

paulschreiber
Copy link
Member

Description

Add fallback page title to Terraso home page when first name is missing.

tm-ruxandra
tm-ruxandra approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@tm-ruxandra tm-ruxandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be helpful to add a test for displaying the user's name on screen in both cases (seems like there's some precedent for testing content in Home.test.js). otherwise lgtm

@paulschreiber paulschreiber merged commit 4fca5e1 into main Mar 7, 2024
9 checks passed
@paulschreiber paulschreiber deleted the fix/fallback-title branch March 11, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tm-ruxandra tm-ruxandra tm-ruxandra approved these changes

@josebui josebui josebui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulschreiber @josebui @tm-ruxandra