test: mock useIsMounted to prevent intermittently failing tests #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining the place information by name, `useIsMounted` is called to determine if the boundingBox must be set. See: src/landscape/components/LandscapeForm/BoundaryStep/index.js During tests, it was found that `useIsMounted` returns sometimes true, sometimes false. This causes tests to sometimes uses the response from `getPlaceInfoByName`, and sometimes to not. During tests, it seemed that the response should always be the non-mounted one. Mocking `useIsMounted` enforces this for all tests.
Jest will happily mock even non-imported objects, and the codestyle imposes to use all defined variables.
nobe4
force-pushed
the
fix_intermitently_failing_tests
branch
from
e97b441 to
e0932b3
Compare
josebui
reviewed
Feb 23, 2024
src/landscape/components/LandscapeForm/BoundaryStepNewBoundariesFile.test.js
Outdated
Show resolved
Hide resolved
…esFile.test.js Co-authored-by: Jose Buitron <[email protected]>
paulschreiber
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When determining the place information by name,
useIsMountedis called to determine if the boundingBox must be set.See: src/landscape/components/LandscapeForm/BoundaryStep/index.js
During tests, it was found that
useIsMountedreturns sometimes true, sometimes false. This causes tests to sometimes uses the response fromgetPlaceInfoByName, and sometimes to not.During tests, it seemed that the response should always be the non-mounted one. Mocking
useIsMountedenforces this for all tests.I could confirm locally that sometimes the test fails. After the update, it never failed again; hopefully it won't fail on CI.