Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Shareable file resource link #1451

Merged
merged 23 commits into from
Feb 19, 2024
Merged

feat: Shareable file resource link #1451

merged 23 commits into from
Feb 19, 2024

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Jan 24, 2024 •
edited
Loading

Description

  • Shareable resource file for Landscapes and groups

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

Verification steps

Screenshot 2024-02-07 at 3 58 52 PM
Screenshot 2024-02-07 at 3 58 31 PM
Screenshot 2024-02-07 at 3 58 21 PM
Screenshot 2024-02-07 at 3 58 15 PM

@josebui josebui self-assigned this Jan 24, 2024
@josebui josebui force-pushed the feat/shareable-resource branch 2 times, most recently from a1a3c3b to 62eeaff Compare February 7, 2024 20:47
@josebui josebui marked this pull request as ready for review February 7, 2024 20:59
paulschreiber
paulschreiber reviewed Feb 7, 2024
View reviewed changes
src/sharedData/sharedDataConstants.js Outdated Show resolved Hide resolved
src/navigation/components/Routes.js Outdated Show resolved Hide resolved
paulschreiber
paulschreiber requested changes Feb 15, 2024
View reviewed changes
src/group/components/GroupView.test.js Outdated Show resolved Hide resolved
src/group/components/GroupView.test.js Outdated Show resolved Hide resolved
src/group/components/GroupView.test.js Outdated Show resolved Hide resolved
src/group/components/GroupView.test.js Outdated Show resolved Hide resolved
src/localization/locales/en-US.json Outdated Show resolved Hide resolved
src/sharedData/sharedDataConstants.js Outdated Show resolved Hide resolved
src/sharedData/sharedDataConstants.js Outdated Show resolved Hide resolved
src/group/components/GroupView.test.js Outdated Show resolved Hide resolved
josebui added 18 commits February 15, 2024 16:56
@josebui
chore: Updated shared version
fbfe4bf
@josebui
feat: Added share data enry dialog for group data entries
f316e89
@josebui
feat: WIP change shared resource access
a5bcfd1
@josebui
fix: Save share access change
2f8ce2e
@josebui
fix: Disable changing share access if not allowed
0237bb0
@josebui
feat: WIP shared resource download page
addaca3
@josebui
feat: Shared resource page
aaf7fa7
@josebui
chore: Fixed tests
0ce68d4
@josebui
fix: Improved download route, improved constant name
0af2e16
@josebui
fix: Fixed join message from download screen
318d0f9
@josebui
fix: Improved landscape download shared resource url
fd9bef0
@josebui
fix: Removed none option, fixed success message when updating access
029b6af
@josebui
fix: Removed not needed padding
693e86b
@josebui
chore: Added es translations
ae6b4f9
@josebui
fix: Reset success message when closing dialog
82d8ac3
@josebui
fix: Added warning for all access
3bf3084
@josebui
fix: Fixed none option from tests
b700513
@josebui
fix: Make information message have the same style
753e82c
@josebui josebui force-pushed the feat/shareable-resource branch from d25d2e8 to 753e82c Compare February 15, 2024 22:05
paulschreiber
paulschreiber reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark the conversations as resolved (when they are resolved).

src/group/components/GroupView.test.js Outdated Show resolved Hide resolved
@josebui josebui merged commit b1fd3a3 into main Feb 19, 2024
8 of 9 checks passed
@josebui josebui deleted the feat/shareable-resource branch February 19, 2024 14:46
@paulschreiber paulschreiber mentioned this pull request Feb 22, 2024
Merged
@paulschreiber paulschreiber restored the feat/shareable-resource branch February 28, 2024 18:56
@paulschreiber paulschreiber deleted the feat/shareable-resource branch February 28, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschreiber paulschreiber paulschreiber approved these changes

Assignees

@josebui josebui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josebui @paulschreiber