Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: closed group membership fixes #1408

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fix: closed group membership fixes #1408

merged 3 commits into from
Jan 11, 2024

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Jan 10, 2024 •
edited
Loading

Description

  • Send membership status when updating user role
  • Avoid change membership card membership while user is requesting for access

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

Verification steps

@josebui josebui self-assigned this Jan 10, 2024
@josebui josebui marked this pull request as ready for review January 10, 2024 19:31
@josebui josebui requested a review from paulschreiber January 10, 2024 19:31
@josebui josebui merged commit 5dde36c into main Jan 11, 2024
10 of 11 checks passed
@josebui josebui deleted the fix/closed-group-membership branch January 11, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschreiber paulschreiber paulschreiber approved these changes

Assignees

@josebui josebui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josebui @paulschreiber