Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Block navigation in visualization form #1356

Merged
merged 4 commits into from
Dec 19, 2023
Merged

feat: Block navigation in visualization form #1356

merged 4 commits into from
Dec 19, 2023

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Dec 7, 2023 •
edited
Loading

Description

  • Block navigation after step 1 and unblock after save

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

@josebui josebui self-assigned this Dec 7, 2023
@josebui josebui force-pushed the feat/visualization-navigation-blocker branch from 79040ba to 26154e3 Compare December 11, 2023 15:47
@josebui josebui marked this pull request as ready for review December 11, 2023 15:53
@paulschreiber
Copy link
Member

@josebui Please add ES translations.

@josebui josebui merged commit c8f88df into main Dec 19, 2023
8 of 9 checks passed
@josebui josebui deleted the feat/visualization-navigation-blocker branch December 19, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschreiber paulschreiber paulschreiber approved these changes

Assignees

@josebui josebui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josebui @paulschreiber