Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: middle truncate long file names in shared files list #1339

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

paulschreiber
Copy link
Member

Description

Middle truncate long file names in shared files list.

Checklist

  • Corresponding issue has been opened
  • Verified on mobile
  • Verified on desktop

Related Issues

Fixes #1277.

@paulschreiber paulschreiber requested a review from josebui December 1, 2023 18:41
* add useCallback to prepEllipses
* add dependencies to to measuredParent
* declare prepEllipses and measuredParent separately
Copy link
Contributor

@josebui josebui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added a small suggestion

@paulschreiber paulschreiber merged commit e256868 into main Dec 1, 2023
8 of 9 checks passed
@paulschreiber paulschreiber deleted the fix/long-file-names branch February 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In shared file module, file name should truncate when it reaches the width of the column.
2 participants