Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: on landscape map, link to profile #1334

Merged
merged 4 commits into from
Nov 29, 2023
Merged

fix: on landscape map, link to profile #1334

merged 4 commits into from
Nov 29, 2023

Conversation

paulschreiber
Copy link
Member

@paulschreiber paulschreiber commented Nov 28, 2023

Description

On embedded landscape map, add link to public landscape profile.

Checklist

  • Corresponding issue has been opened
  • English strings reviewed and copyedited
  • Strings are localized
  • Verified on mobile
  • Verified on desktop

Related Issues

Fixes #863.

@paulschreiber paulschreiber changed the title Fix/profile link fix: on landscape map, link to profile Nov 28, 2023
@paulschreiber paulschreiber marked this pull request as ready for review November 28, 2023 22:31
@paulschreiber
Copy link
Member Author

@josebui Please review the code and translate the map_profile_link_text string.

@paulschreiber paulschreiber merged commit 1f752ca into main Nov 29, 2023
8 of 9 checks passed
@paulschreiber paulschreiber deleted the fix/profile-link branch November 29, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded landscape map should provide a link to the landscape profile.
2 participants