Skip to content

Commit

Permalink
fix: standardize node-related workflows (#1067)
Browse files Browse the repository at this point in the history
* fix: remove feature/landscape-profile branch from workflows

* chore: add tool-versions file with node

* fix: use tool-versions for node version; use npm ci to install
  • Loading branch information
paulschreiber authored Jul 14, 2023
1 parent 0e699bb commit fb4cc5d
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 17 deletions.
18 changes: 8 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@ on:
push:
branches:
- main
- feature/landscape-profile
pull_request:
branches:
- main
- feature/landscape-profile

jobs:
lint:
Expand All @@ -21,11 +19,11 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version-file: '.tool-versions'
cache: 'npm'

- name: Install dependencies
run: npm install
run: npm ci

- name: Typecheck ts code
run: npm run check-ts
Expand All @@ -46,11 +44,11 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version-file: '.tool-versions'
cache: 'npm'

- name: Install dependencies
run: npm install
run: npm ci

- name: Run test
run: npm run test
Expand All @@ -67,11 +65,11 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version-file: '.tool-versions'
cache: 'npm'

- name: Install dependencies
run: npm install
run: npm ci

- name: Run test
run: npm run test-coverage
Expand All @@ -86,11 +84,11 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version-file: '.tool-versions'
cache: 'npm'

- name: Install dependencies
run: npm install
run: npm ci

- name: Run build
run: npm run build
1 change: 0 additions & 1 deletion .github/workflows/check-commits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
pull_request:
branches:
- main
- feature/landscape-profile
types:
- opened
- edited
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ name: "CodeQL"

on:
push:
branches: [ main, feature/landscape-profile ]
branches: [ main ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ main, feature/landscape-profile ]
branches: [ main ]
schedule:
- cron: '34 6 * * 4'

Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/localization.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@ on:
push:
branches:
- main
- feature/landscape-profile
pull_request:
branches:
- main
- feature/landscape-profile

jobs:
missing-keys:
Expand All @@ -21,11 +19,11 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18'
node-version-file: '.tool-versions'
cache: 'npm'

- name: Install dependencies
run: npm install
run: npm ci

- name: Run missing keys check
run: npm run localization-check-missing
1 change: 1 addition & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodejs 18.16.0

0 comments on commit fb4cc5d

Please sign in to comment.