-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: standardize event tracking for link sharing
add a common analytics event for sharing and reuse it in both copy-link share button usages in the application. add a test for the new common code.
- Loading branch information
1 parent
73035a2
commit d6bb94c
Showing
5 changed files
with
92 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
* Copyright © 2021-2024 Technology Matters | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as published | ||
* by the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see https://www.gnu.org/licenses/. | ||
*/ | ||
|
||
import { useMemo } from 'react'; | ||
|
||
import { useAnalytics } from 'monitoring/analytics'; | ||
|
||
export const useShareEvent = () => { | ||
const { trackEvent } = useAnalytics(); | ||
const pageUrl = useMemo(() => window.location, []); | ||
|
||
const onShare = method => { | ||
trackEvent('share', { props: { url: pageUrl.toString(), method } }); | ||
}; | ||
|
||
return { onShare }; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright © 2021-2023 Technology Matters | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as published | ||
* by the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see https://www.gnu.org/licenses/. | ||
*/ | ||
import { render } from 'tests/utils'; | ||
|
||
import { useAnalytics } from 'monitoring/analytics'; | ||
import { useShareEvent } from 'monitoring/events'; | ||
|
||
jest.mock('monitoring/analytics', () => ({ | ||
...jest.requireActual('monitoring/analytics'), | ||
useAnalytics: jest.fn(), | ||
})); | ||
|
||
const Component = () => { | ||
const { onShare } = useShareEvent(); | ||
|
||
onShare('test'); | ||
return <div></div>; | ||
}; | ||
|
||
test('Events: onShare', async () => { | ||
const trackEvent = jest.fn(); | ||
useAnalytics.mockReturnValue({ | ||
trackEvent, | ||
}); | ||
|
||
const expectedUrl = window.location.toString(); | ||
|
||
await render(<Component />); | ||
|
||
const eventCall = trackEvent.mock.calls[0]; | ||
expect(eventCall[0]).toStrictEqual('share'); | ||
expect(eventCall[1]).toStrictEqual({ | ||
props: { | ||
method: 'test', | ||
url: expectedUrl, | ||
}, | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters