build(deps): Bump react-hook-form from 7.50.1 to 7.51.2 (#1698)

* build(deps): Bump react-hook-form from 7.50.1 to 7.51.2

Bumps [react-hook-form](https://github.com/react-hook-form/react-hook-form) from 7.50.1 to 7.51.2.
- [Release notes](https://github.com/react-hook-form/react-hook-form/releases)
- [Changelog](https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md)
- [Commits](react-hook-form/react-hook-form@v7.50.1...v7.51.2)

---
updated-dependencies:
- dependency-name: react-hook-form
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: Removed not working testing-library rule, added waitFor

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Jose Buitron <[email protected]>

.eslintrc

@@ -21,6 +21,7 @@
   "rules": {
     "prettier/prettier": "error",
     "testing-library/no-unnecessary-act": "off",
+    "testing-library/prefer-find-by": "off",
     "curly": "error"
   }
 }

package.json

@@ -39,7 +39,7 @@
     "react-error-boundary": "^4.0.13",
     "react-helmet-async": "^2.0.4",
     "react-highlight-words": "^0.20.0",
-    "react-hook-form": "^7.50.1",
+    "react-hook-form": "^7.51.2",
     "react-i18next": "^14.1.1",
     "react-redux": "^8.1.3",
     "react-router-dom": "^6.23.0",

src/landscape/components/LandscapeForm/ProfileUpdate.test.js

@@ -14,7 +14,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see https://www.gnu.org/licenses/.
  */
-import { fireEvent, render, screen, within } from 'tests/utils';
+import { fireEvent, render, screen, waitFor, within } from 'tests/utils';
 import React from 'react';
 import { act } from 'react-dom/test-utils';
 import { useParams } from 'react-router-dom';
@@ -50,6 +50,10 @@ const setup = async () => {
     });
     fireEvent.change(combobox, { target: { value: newValue } });
 
+    await waitFor(() =>
+      expect(screen.getByRole('listbox', { name })).toBeInTheDocument()
+    );
+
     const optionsList = screen.getByRole('listbox', { name });
 
     if (isNew) {