fix: Removed not working testing-library rule, added waitFor

techmatters · Apr 29, 2024 · b875af5 · b875af5
1 parent 8dd32f4
commit b875af5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.eslintrc b/.eslintrc
@@ -21,6 +21,7 @@
   "rules": {
     "prettier/prettier": "error",
     "testing-library/no-unnecessary-act": "off",
+    "testing-library/prefer-find-by": "off",
     "curly": "error"
   }
 }
diff --git a/src/landscape/components/LandscapeForm/ProfileUpdate.test.js b/src/landscape/components/LandscapeForm/ProfileUpdate.test.js
@@ -14,7 +14,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see https://www.gnu.org/licenses/.
  */
-import { fireEvent, render, screen, within } from 'tests/utils';
+import { fireEvent, render, screen, waitFor, within } from 'tests/utils';
 import React from 'react';
 import { act } from 'react-dom/test-utils';
 import { useParams } from 'react-router-dom';
@@ -50,6 +50,10 @@ const setup = async () => {
     });
     fireEvent.change(combobox, { target: { value: newValue } });
 
+    await waitFor(() =>
+      expect(screen.getByRole('listbox', { name })).toBeInTheDocument()
+    );
+
     const optionsList = screen.getByRole('listbox', { name });
 
     if (isNew) {