fix: Added datalayer validation, fixed strings

techmatters · May 10, 2024 · a925bb6 · a925bb6
1 parent 3c643b1
commit a925bb6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/localization/locales/en-US.json b/src/localization/locales/en-US.json
@@ -912,7 +912,7 @@
         "form_delete_chapter_confirm_title": "Delete “{{name}}”?",
         "form_delete_chapter_confirm_message": "Are you sure you want to delete the chapter {{name}}?",
         "form_delete_chapter_confirm_button_tooltip": "Delete chapter “{{name}}”",
-        "form_chapter_location_button": "Set Map Location",
+        "form_chapter_location_button": "Edit Map",
         "form_chapter_alignment_buttons": "Set alignment",
         "form_chapter_alignment_left": "Align Left",
         "form_chapter_alignment_center": "Align Center",
@@ -924,7 +924,7 @@
         "form_location_dialog_title": "Set map location for <1>{{title}}</1>",
         "form_location_dialog_title_blank": "Set map location",
         "location_dialog_cancel_button": "Cancel",
-        "location_dialog_confirm_button": "Set Location",
+        "location_dialog_confirm_button": "Save Map",
         "view_title_outline": "Outline",
         "breadcrumbs_view": "{{title}}",
         "breadcrumbs_tool_home": "Terraso Story Maps",

diff --git a/src/storyMap/components/StoryMapForm/ChapterForm.js b/src/storyMap/components/StoryMapForm/ChapterForm.js
@@ -202,6 +202,9 @@ const ChapterForm = ({ theme, record }) => {
 
   const onDataLayerChange = useCallback(
     dataLayerConfig => {
+      if (!dataLayerConfig?.id) {
+        return;
+      }
       const baseEvents = dataLayerConfig
         ? LAYER_TYPES.map(name => ({
             layer: `${dataLayerConfig.id}-${name}`,

diff --git a/src/storyMap/components/StoryMapForm/TitleForm.js b/src/storyMap/components/StoryMapForm/TitleForm.js
@@ -65,6 +65,10 @@ const TitleForm = props => {
 
   const onDataLayerChange = useCallback(
     dataLayerConfig => {
+      if (!dataLayerConfig?.id) {
+        return;
+      }
+
       const baseEvents = LAYER_TYPES.map(name => ({
         layer: `${dataLayerConfig.id}-${name}`,
         opacity: getLayerOpacity(name, dataLayerConfig),