fix: clean up delete tooltip (#1693)

* fix: remove MUI tooltip for delete; use title (elimiates warning) * fix: use "delete" in delete tooltip
techmatters · Mar 27, 2024 · 0efb15f · 0efb15f
1 parent a8aabed
commit 0efb15f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/src/localization/locales/en-US.json b/src/localization/locales/en-US.json
@@ -666,8 +666,8 @@
         "upload_link_form.name": "$t(sharedData.upload_name_label)",
         "upload_link_form.description": "$t(sharedData.upload_description_label)",
         "addSharedDataLink.terraso_api.invalid": "Invalid $t(sharedData.upload_{{field}}_label)",
-        "link_delete_tooltip": "Remove link “{{name}}”.",
-        "file_delete_tooltip": "Remove file “{{name}}”.",
+        "link_delete_tooltip": "Delete link “{{name}}”.",
+        "file_delete_tooltip": "Delete file “{{name}}”.",
         "visualization_unsaved_changes_title": "Leave Map?",
         "visualization_unsaved_changes_message": "You have unsaved changes that will be lost if you leave the page.",
         "shared_resource_download_no_preview": "No file preview available",

diff --git a/src/sharedData/components/SharedDataEntryBase.js b/src/sharedData/components/SharedDataEntryBase.js
@@ -56,7 +56,6 @@ const SharedDataEntryBase = props => {
     ShareComponent,
     fileSize,
     resourceType,
-    deleteTooltip,
   } = props;
   const [isEditingName, setIsEditingName] = useState(false);
   const [isEditingDescription, setIsEditingDescription] = useState(false);
@@ -264,9 +263,14 @@ const SharedDataEntryBase = props => {
               loading={processing}
               variant="text"
               buttonProps={{
-                title: t('sharedData.delete_label', {
-                  name: dataEntry.name,
-                }),
+                title: t(
+                  dataEntry.entryType === 'LINK'
+                    ? 'sharedData.link_delete_tooltip'
+                    : 'sharedData.file_delete_tooltip',
+                  {
+                    name: dataEntry.name,
+                  }
+                ),
               }}
               confirmTitle={t('sharedData.delete_confirm_title', {
                 name: dataEntry.name,
@@ -284,7 +288,6 @@ const SharedDataEntryBase = props => {
                   ? 'sharedData.delete_link_confirm_button'
                   : 'sharedData.delete_file_confirm_button'
               )}
-              tooltip={deleteTooltip}
             >
               <DeleteIcon
                 sx={{

diff --git a/src/sharedData/components/SharedDataEntryLink.js b/src/sharedData/components/SharedDataEntryLink.js
@@ -73,11 +73,6 @@ const SharedDataEntryLink = props => {
     return url.hostname;
   }, [dataEntry.url]);
 
-  const toolTipKey =
-    dataEntry.entryType === 'LINK'
-      ? 'sharedData.link_delete_tooltip'
-      : 'sharedData.file_delete_tooltip';
-
   return (
     <SharedDataEntryBase
       sharedResource={sharedResource}
@@ -94,9 +89,6 @@ const SharedDataEntryLink = props => {
       )}
       DownloadComponent={DownloadComponent}
       info={domain}
-      deleteTooltip={t(toolTipKey, {
-        name: dataEntry.name,
-      })}
     />
   );
 };