fix: project user list updating #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 3, 2023 14:23
No styling applied yet!
This input is intended for the add user to project screen. It will just encapsulate the logic of validating the user emails exists and displaying an error message if invalid. In the future the error message may be more complex, like displaying a modal or something, so I've decided to make this a whole separate component.
The GraphQL query does not return user preferences, which is kind of what we want anyways!
(The alt text will likely be removed at a certain point, need to figure out what the best practice is here).
…-user-to-project-screen
david-code
force-pushed
the
fix/project-user-list-updating
branch
2 times, most recently
from
4598bc0 to
e405dfd
Compare
david-code
force-pushed
the
fix/project-user-list-updating
branch
from
e405dfd to
34ad9e9
Compare
…ect-user-list-updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously this screen just accepted a list of users as a route param and removed the user when they clicked on the remove button. I've updated this to instead read the list of users/members from the redux store, which makes more sense.
Relies on techmatters/terraso-client-shared#122
Also includes some styling fixes.
Checklist
Related Issues
Fixes #....
Verification steps