Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: site dashboard scaffolding! #459

Merged
merged 7 commits into from
Oct 13, 2023
Merged

feat: site dashboard scaffolding! #459

merged 7 commits into from
Oct 13, 2023

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Sep 29, 2023

Description

Scaffolds the site dashboard so it is ready for future data inputs work. Creates the site tabs, and ability to add/edit a site's depth intervals so that all data inputs can be navigated to. Still needs a bunch more work, but wanted to make the code available now since it's interrelated with the relevant client-shared/backend PRs and paul asked me to! depends on techmatters/terraso-client-shared#105 and techmatters/terraso-backend#843

Checklist

  • Corresponding issue has been opened

Fixes #395
Fixes #432
Fixes #396
Fixes #456

Limitations:

  • project inputs screen raises warnings (but is functional if not beautiful)
  • new formswitch component raises warnings (but is functional)
  • project required data inputs are not wired to individual sites yet
  • "apply to all intervals" checkbox on individual site depth interval editor does nothing
  • no implementation of site or project depth interval presets
  • delete site button needs modal confirmation
  • redux structure of soilIdSlice doesn't handle newly-created sites
  • no delete depth interval button or modal warnings when changing depth intervals

@shrouxm shrouxm requested a review from david-code September 29, 2023 01:47
@shrouxm shrouxm force-pushed the feat/site-dashboard-tabs branch from 88a8d10 to 81f71a2 Compare October 6, 2023 03:02
@shrouxm shrouxm marked this pull request as ready for review October 6, 2023 03:03
@shrouxm
Copy link
Member Author

shrouxm commented Oct 6, 2023

@david-code ok this kept growing & growing i am cutting off adding things here. there will need to be a follow-up PR for UI polish once the design is finalized, and a few buttons/interactions don't work yet, but this adds tabs to the site dashboard, UI to add/edit depth intervals, and UI to edit project soil settings!

@shrouxm shrouxm force-pushed the feat/site-dashboard-tabs branch from 81f71a2 to 2335cfb Compare October 13, 2023 18:25
@shrouxm shrouxm force-pushed the feat/site-dashboard-tabs branch from 2335cfb to 596d1b2 Compare October 13, 2023 19:27
@shrouxm shrouxm merged commit 1971278 into main Oct 13, 2023
4 checks passed
@shrouxm shrouxm deleted the feat/site-dashboard-tabs branch October 13, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants