Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tooltip component design updates #2499

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: tooltip component design updates #2499

merged 2 commits into from
Nov 21, 2024

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Nov 19, 2024

Description

Updates the Tooltip component to match the new design spec. Waiting on confirmation of a couple things in this Figma thread before fully ready to merge.

Checklist

  • Corresponding issue has been opened

Related Issues

Related to #1776

Verification steps

Tooltip component should look like the design. I believe the only example right now is on the ? on the create site screen.

@paulschreiber
Copy link
Member

@shrouxm do we want to use this as an opportunity to get rid of NativeBase in tooltips?

@shrouxm
Copy link
Member Author

shrouxm commented Nov 20, 2024

react-native-paper doesn't offer a tooltip component which is able to match the spec, so it would increase the effort required to find and vet another library and/or implement it ourselves. this doesn't further entrench us in nativebase and it at least gets us compliant with the spec, so i don't see any reason to couple that work together.

Copy link
Contributor

@tm-ruxandra tm-ruxandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment would have been to get us off of NativeBase if possible, but maybe that just isn't a practical goal right now.

@shrouxm shrouxm merged commit 6e2dcf5 into main Nov 21, 2024
10 checks passed
@shrouxm shrouxm deleted the feat/tooltip-component branch November 21, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants