feat: offline-mode soil updates #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on feature flag state
tm-ruxandra
commented
Oct 15, 2024
| /** | ||
| * The soil data fields which are covered by the update action. | ||
| */ | ||
| export const SOIL_DATA_UPDATE_FIELDS = [ |
There was a problem hiding this comment.
I am open to a better means of enumerating these fields in the future (via some sort of codegen?), but this was the best option that the other devs and I could come up with.
tm-ruxandra
commented
Oct 15, 2024
| import * as localSoilData from 'terraso-mobile-client/model/soilId/actions/localSoilDataActions'; | ||
| import {AppState} from 'terraso-mobile-client/store'; | ||
|
|
||
| export const updateSoilDataThunk = async ( |
There was a problem hiding this comment.
Unsure if it makes more sense to just merge the thunk methods with the non-thunk methods -- I suspect that the separation isn't necessary, but somehow this felt cleaner to me.
knipec
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement and unit test client-side versions of the four soil data mutations:
updateSoilData,deleteSoilDataDepthInterval,updateSoilDataDepthInterval, andupdateDepthDependentSoilData. When the offline feature flag is turned on, the client will use the local logic rather than making graphQL calls, and the resulting data will be ingested by the redux state.Checklist
Related Issues
Fixes #2277
Verification steps
Open the app with the offline feature flag turned on. Verify that all soil data actions (editing site settings, depth intervals, taking readings etc) behave as expected.