-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global redux actions #2301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrouxm
force-pushed
the
feat/global-redux-actions
branch
2 times, most recently
from
October 14, 2024 20:42
c0d314f
to
232b743
Compare
shrouxm
force-pushed
the
feat/global-redux-actions
branch
from
October 14, 2024 21:01
232b743
to
502375e
Compare
shrouxm
force-pushed
the
feat/global-redux-actions
branch
from
October 14, 2024 21:38
502375e
to
7d4c0c9
Compare
1 task
shrouxm
force-pushed
the
feat/global-redux-actions
branch
from
October 14, 2024 22:40
7d4c0c9
to
1b67911
Compare
shrouxm
commented
Oct 14, 2024
shrouxm
commented
Oct 15, 2024
shrouxm
commented
Oct 15, 2024
shrouxm
force-pushed
the
feat/global-redux-actions
branch
from
October 22, 2024 16:25
1b67911
to
e5020eb
Compare
tm-ruxandra
approved these changes
Oct 22, 2024
shrouxm
force-pushed
the
feat/global-redux-actions
branch
from
October 24, 2024 23:13
9aadf66
to
a7d4a3c
Compare
shrouxm
force-pushed
the
feat/global-redux-actions
branch
from
October 24, 2024 23:14
a7d4a3c
to
2e503f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please review one commit at a time. git really mangled the diff, so i rewrote the commit history and it's way cleaner/more comprehensible if you go one at a time and read the descriptions.
Ready for first round of review/discussion. Explanation (will crystallize into docs in the code once consensus is reached):
The only functional difference this PR introduces is that there are no longer actions which modify the state over the course of several dispatches. In order to make that functional change, I had to do a decent chunk of refactoring. I only want to merge this PR if there's consensus that the new shape of our redux code is an improvement on the old shape.
Changes to codebase
createGlobalReducer
which allows you to create a reducer which can act on the entire redux state at once, rather than just a slice at a timefeatures of the new shape of the code
Checklist
Related Issues
Fixes #2162
Verification steps
Everything should work the same.