fix: make header height context available to all overlay sheets #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knipec
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Just to confirm understanding: The first OverlaySheet would be a child of the ScreenScaffold, so would receive the headerHeight via the context, but subsequent nested OverlaySheets would not receive it because they'd exist at some other level of the component hierarchy that was not a child of the ScreenScaffold -- is that accurate?
|
@knipec that's correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had issues with nested overlay sheets opening to inconsistent heights, which in turn made their close buttons inaccessible. This was because the
HeaderHeightcontext that tells them their opening limit is scoped to theScreenScaffoldcomponent, which is context that nested sheets do not have (since they are opening in theBottomSheetModalProvideroutside of the scaffold). This fixes the issue by makingHeaderHeightcontext available to the entire app, withScreenScaffoldjust setting the current value as a side effect.Checklist
Related Issues
#1651
Verification steps
Open info overlay sheets, including the nested ones in Soil ID, and verify that all open to the expected height and can be closed on both IOS and Android.