fix: Remove 'Create Site Here' button on overlay sheet, add bottom margin #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pressing the "Create Site Here" button would not close the soil info overlay sheet that it was on (though it would navigate to a different sheet underneath the open overlay sheet). This was undesirable. If we wanted to fix it, we could probably pass the button a ref to the overlay sheet to allow the button to close the overlay sheet on press, but Courtney suggested just removing the button. I think this makes sense because the soil info sheet is just specific to that soil, and if you want to create a site from that temporary location, you can just close the overlay sheet to access another "Create Site Here" button.
Also added a bit of margin at the bottom to let it breathe and not feel like the content is so close to the edge of the screen.
Related Issues
Fixes #1556
Screenshot