feat: improve UX of location permission requests #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrouxm
force-pushed
the
feat/rerequest-location-permissions
branch
from
37cf515 to
90c462e
Compare
paulschreiber
force-pushed
the
feat/rerequest-location-permissions
branch
from
474a02b to
cf20d67
Compare
paulschreiber
force-pushed
the
feat/rerequest-location-permissions
branch
from
cf20d67 to
efbc7a4
Compare
paulschreiber
force-pushed
the
feat/rerequest-location-permissions
branch
from
efbc7a4 to
863aa36
Compare
knipec
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves UX of location permission requests by:
Checklist
Related Issues
Fixes #1645
In the course of working on this PR, I discovered two new bugs: #1749 and #1750. I confirmed they are pre-existing (not introduced by this PR), and could not find an easy workaround, so I'm just filing them and leaving them in the backlog.