fix: Decrease font size of soil match percent, use adjustsFontSizeToFit #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulschreiber
approved these changes
Jul 3, 2024
|
Merging so folks can try it on their devices, and open to Courtney's feedback! |
|
It looks great to me on Android phone and iPad. The smaller font size is just fine. Thanks! |
CourtneyLee333
requested review from
CourtneyLee333
and removed request for
CourtneyLee333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another attempt at preventing the "100%" from wrapping (or truncating) -- this time by decreasing the font size and using adjustsfontSizeToFit onto one line.
Related Issues
Addresses #1635
However, I still don't understand why:
a) With 30px or 32px font size, we'd get "100" without the "%" sign, even with adjustsFontSizeToFit?
b) Why font size and Box width are both specified in fixed pixels but not
Before --> After:
--> 
And also any individual percentage, like the "100%", will get smaller if it would overflow its box, like this (but note this is not the new 24px font size):
