fix: soil id data caching #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm-ruxandra
force-pushed
the
fix/soil-id-cache
branch
from
5bf1cfb to
9bc24f4
Compare
knipec
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App was locking up because multiple soil ID components were rendering at once, which wasn't a supported use-case in the initial loading implementation. This caused contention over the soil ID redux store, resulting in an infinite cycle of queries canceling each other out. Update the soil ID data hook to use the new cache-based implementation of the redux store slice.
Checklist
Related Issues
#1647
Verification steps
Open soil ID views through both the map and sites list. Verify that the app does not lock up anymore. Verify that site data is loaded once and continues to be available until the user navigates way from the site. Verify that data displayed on map callouts persists while the user views site data.