feat: Show loading indicators and failure indicators for soil id #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulschreiber
requested changes
Jul 2, 2024
dev-client/src/screens/LocationScreens/components/soilId/SoilIdMatchesSection.tsx
Outdated
Show resolved
Hide resolved
dev-client/src/screens/LocationScreens/components/LocationPrediction.tsx
Outdated
Show resolved
Hide resolved
dev-client/src/screens/HomeScreen/components/TemporaryLocationCallout.tsx
Show resolved
Hide resolved
dev-client/src/screens/HomeScreen/components/TemporaryLocationCallout.tsx
Outdated
Show resolved
Hide resolved
dev-client/src/screens/LocationScreens/components/LocationPrediction.tsx
Outdated
Show resolved
Hide resolved
…ding spinner, error, no matches, or the top match
…aryLocationCallout and LocationPrediction on dashboard
knipec
force-pushed
the
feat/soil-id-error-loading
branch
from
67392da to
092d1ff
Compare
paulschreiber
approved these changes
Jul 8, 2024
paulschreiber
pushed a commit
that referenced
this pull request
Jul 8, 2024
Commits: * feat: Location dashboard displays "Loading..." or "No matches" or soil id results * feat: Add loading spinner for matches section in Soil ID screen * feat: error and alert boxes appear for soil id screen's top soil matches section * feat: temporary location callout displays each datum section with loading spinner, error, no matches, or the top match * refactor: Move message box components to separate files * refactor: Consolidate no matches and error strings * refactor: get soil match and ecological site similarly between TemporaryLocationCallout and LocationPrediction on dashboard * fix: use consistent apostrophe characters in strings * fix: minor styling and refactoring * fix: Remove unused import after rebase * refactor: Consolidate some duplicate logic with SoilIdStatusDisplay * fix: Update test snapshot to accomodate soil id tile existing regardless of status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Implements techmatters/terraso-product#895 (except request timeout behavior, which I intend to be a future PR)