fix: request permissions before using camera/media library in image picker #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulschreiber
requested changes
May 23, 2024
shrouxm
force-pushed
the
fix/image-picker-permisisons
branch
from
159d02a to
1806b42
Compare
shrouxm
commented
May 23, 2024
tm-ruxandra
approved these changes
Jun 4, 2024
paulschreiber
force-pushed
the
fix/image-picker-permisisons
branch
from
c3d5767 to
60fac74
Compare
|
@shrouxm does this need any more work before it can be merged? |
shrouxm
force-pushed
the
fix/image-picker-permisisons
branch
from
e766327 to
52b0843
Compare
|
@paulschreiber it looks like the issues that were blocking merging this got fixed at some point so should be good to go once you approve! |
paulschreiber
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What it says on the tin. In draft til I can validate on iOS. Right now when you fix the permissions in settings from the slope screen and then return to the app, you need to leave/re-enter the slope screen to get the app to pick up on the change, the
usePermissionshook doesn't seem to re-render the screen. not sure if there's a better workaround.Checklist
Related Issues
Fixes #1328