feat: Enable calling the Soil ID API with input from frontend #588
Conversation
…hes simultaneously
tm-ruxandra
changed the title
|
|
||
| export const soilDataSlopePercent = ( | ||
| data: SoilData, | ||
| ): Maybe<number> | undefined => { |
There was a problem hiding this comment.
Ok I know it's weird to review after you already submitted this but just realized -- is the Maybe necessary here? Can we just make it undefined if it's ever null?
There was a problem hiding this comment.
I had the thought. This is definitely more annoying, but the convention in code that interacts with the GraphQL layer seems to use Maybe | undefined all over the place and I thought it'd be better to keep consistent with that standard, since all this is in the client-shared codebase.
| * When soil data is available, we use the data-based soil match API. | ||
| * When the input is only a location, we use the location-based soil match API. |
There was a problem hiding this comment.
@tm-ruxandra @paulschreiber FYI: Oh actually it appears I was misinterpreting the code. It appears that even a site with no data entered will call the data-based one. So it was in fact correct to say the division is Site vs Temporary Location.
Description
(Creating from Ruxandra's work)
Related Issues
Implements #653
Verification steps
Look at the soil ID info screen for a given soil (need the corresponding mobile-client work)