feat: site soil async #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-code
requested review from
shrouxm,
ajabeckett and
paulschreiber
and removed request for
ajabeckett
paulschreiber
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds reducers that update the soil ID state automatically when a user presses a switch on the soil tab. If the request fails, it rolls back the data and changes the store status to "error".
This implementation is very much a first attempt. The fact that the soil ID update updates the whole soil ID object, and the fact that soil IDs are a list rather than a hash set, make the reverse code a bit hacky. Hopefully in the future we can look into some libraries that will make this sort of operation easier.
Checklist
Related Issues
Fixes #....
Verification steps